Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): waterfall component support footer view #4098

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat(ios): waterfall component support footer view #4098

merged 1 commit into from
Oct 30, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Oct 30, 2024

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Oct 30, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@github-actions github-actions bot added the size: m Denotes a PR that changes 100-499 lines label Oct 30, 2024
@wwwcg wwwcg force-pushed the main branch 2 times, most recently from b624422 to ca66ff6 Compare October 30, 2024 03:52
@wwwcg wwwcg merged commit 0c2a5dd into Tencent:main Oct 30, 2024
21 of 25 checks passed
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Oct 30, 2024
@wwwcg
feat(ios): waterfall component support footer view (Tencent#4098)
c322457 
refactor waterfall component
wwwcg added a commit that referenced this pull request Oct 30, 2024
@wwwcg
feat(ios): waterfall component support footer view (#4098)
8e59529 
refactor waterfall component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan Awaiting requested review from ruifanyuan ruifanyuan is a code owner

@zealotchen0 zealotchen0 Awaiting requested review from zealotchen0 zealotchen0 is a code owner

Assignees
No one assigned
Labels
doc: pages driver: js renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wwwcg